googleapis / googleapis/google-cloud-java
[java-storage] Allow to create presigned URLs using HMAC keys
- Ngôn ngữ chính
- Java
- Star
- 2.1k
- Fork
- 1.2k
- Merge trung bình
- 1 ngày 23 giờ
- Pull request đã merge (30 ngày)
- 154
Mô tả
**Is your feature request related to a problem? Please describe.**
Currently `com.google.cloud.storage.StorageImpl` class allows to create a presigned URL using RSA algorithm. One can pass their own `ServiceAccountSigner` implementation (via `StorageOptions.setCredentials()`) but the algorithm name literal is deeply hard-coded as `GOOG4-RSA-SHA256` (also in `com.google.cloud.storage.SignatureInfo`). It's not possible to efficiently reuse current code to sign URL via HMAC keys (https://cloud.google.com/storage/docs/authentication/signatures#signing-process).
**Describe the solution you'd like**
Allow to pass an algorithm via `StorageOptions`.
**Describe alternatives you've considered**
The only solution I see is to copy/fork all the code. Reflection seems to be too fragile.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.