googleapis / googleapis/google-cloud-java

[java-storage] Allow to create presigned URLs using HMAC keys

Offen
#12,638 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
api: storage type: feature request
Vorherrschende Sprache
Java
Sterne
2.1k
Forks
1.2k
Ø Merge
1 T. 23 Std.
Gemergte PRs (30 T.)
154

Beschreibung

**Is your feature request related to a problem? Please describe.**
Currently `com.google.cloud.storage.StorageImpl` class allows to create a presigned URL using RSA algorithm. One can pass their own `ServiceAccountSigner` implementation (via `StorageOptions.setCredentials()`) but the algorithm name literal is deeply hard-coded as `GOOG4-RSA-SHA256` (also in `com.google.cloud.storage.SignatureInfo`). It's not possible to efficiently reuse current code to sign URL via HMAC keys (https://cloud.google.com/storage/docs/authentication/signatures#signing-process).

**Describe the solution you'd like**
Allow to pass an algorithm via `StorageOptions`.

**Describe alternatives you've considered**
The only solution I see is to copy/fork all the code. Reflection seems to be too fragile.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.