googleapis / googleapis/google-cloud-java

[java-storage] Allow to create presigned URLs using HMAC keys

Aperta
#12,638 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
api: storage type: feature request
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

**Is your feature request related to a problem? Please describe.**
Currently `com.google.cloud.storage.StorageImpl` class allows to create a presigned URL using RSA algorithm. One can pass their own `ServiceAccountSigner` implementation (via `StorageOptions.setCredentials()`) but the algorithm name literal is deeply hard-coded as `GOOG4-RSA-SHA256` (also in `com.google.cloud.storage.SignatureInfo`). It's not possible to efficiently reuse current code to sign URL via HMAC keys (https://cloud.google.com/storage/docs/authentication/signatures#signing-process).

**Describe the solution you'd like**
Allow to pass an algorithm via `StorageOptions`.

**Describe alternatives you've considered**
The only solution I see is to copy/fork all the code. Reflection seems to be too fragile.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.