googleapis / googleapis/google-cloud-cpp

The google-cloud-cpp::*-mocks targets are not exported

オープン
#5,782 コメント 5 件 リアクション 0 件 担当者 1 名 @scotthart が担当を希望しています GitHub で見る
cpp: operator type: feature request
主要言語
C++
スター
659
フォーク
462
平均マージ
1日 2時間
マージ済み PR(30日)
89

説明

These targets are not exported. In practice it does not matter much, because using the library gets you the same `-I` flags, but the applications are missing the `-lgtest*` and `-lgmock*` options.

We need to fix at least the following problems:

- [ ] We need to separate the CMake and pkg-config files for mocks vs. runtime libraries. If we add the mocks to the existing config files then we need to add `find_dependency(gtest)` (and its equivalent in pkg-config lingo) to the config files. It would be very strange to require `googletest` when all you want is to link against the runtime version of the libraries.
- [ ] We need to decide if installing these libraries is optional or not. I think we should **not** make it optional, we have too many knobs already.
- [ ] We need to install these libraries as part of the "development" component (for CMake)
- [ ] We need to add something to the CI builds to verify these libraries are usable once installed.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。