googleapis / googleapis/google-cloud-cpp

The google-cloud-cpp::*-mocks targets are not exported

未关闭
#5,782 5 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@scotthart 已经在做这个了。

开始于 2024年8月21日。

cpp: operator type: feature request
主要语言
C++
星标
659
派生
463
平均合并
1 天 2 小时
30 天内合并 PR
89

描述

These targets are not exported. In practice it does not matter much, because using the library gets you the same -I flags, but the applications are missing the -lgtest* and -lgmock* options.

We need to fix at least the following problems:

  • We need to separate the CMake and pkg-config files for mocks vs. runtime libraries. If we add the mocks to the existing config files then we need to add find_dependency(gtest) (and its equivalent in pkg-config lingo) to the config files. It would be very strange to require googletest when all you want is to link against the runtime version of the libraries.
  • We need to decide if installing these libraries is optional or not. I think we should not make it optional, we have too many knobs already.
  • We need to install these libraries as part of the "development" component (for CMake)
  • We need to add something to the CI builds to verify these libraries are usable once installed.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。