googleapis / googleapis/google-cloud-cpp

The google-cloud-cpp::*-mocks targets are not exported

Abierto
#5,782 5 comentarios 0 reacciones 1 asignado Reclamado por @scotthart Ver en GitHub
cpp: operator type: feature request
Lenguaje dominante
C++
Estrellas
659
Forks
462
Merge medio
1 d 2 h
PR fusionados (30 d)
89

Descripción

These targets are not exported. In practice it does not matter much, because using the library gets you the same `-I` flags, but the applications are missing the `-lgtest*` and `-lgmock*` options.

We need to fix at least the following problems:

- [ ] We need to separate the CMake and pkg-config files for mocks vs. runtime libraries. If we add the mocks to the existing config files then we need to add `find_dependency(gtest)` (and its equivalent in pkg-config lingo) to the config files. It would be very strange to require `googletest` when all you want is to link against the runtime version of the libraries.
- [ ] We need to decide if installing these libraries is optional or not. I think we should **not** make it optional, we have too many knobs already.
- [ ] We need to install these libraries as part of the "development" component (for CMake)
- [ ] We need to add something to the CI builds to verify these libraries are usable once installed.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.