github / github/gh-stack

`gh stack push` advertises atomic updates but invokes `git.Push` with atomic disabled

オープン
#216 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
bug topic: cli - push
主要言語
Go
スター
1.5k
フォーク
70
平均マージ
1日 8時間
マージ済み PR(30日)
7

説明

## Summary

`gh stack push` is documented as pushing every active branch with `--force-with-lease --atomic`, but the command currently invokes the Git push layer with atomicity disabled.

This is present in both `v0.0.8` and the current `main` branch.

## Current behavior

`runPush` calls:

```go
git.Push(remote, activeBranches, true, false)
```

The fourth argument is `atomic`, so this requests lease-protected pushing without `--atomic`:

- [`cmd/push.go`](https://github.com/github/gh-stack/blob/v0.0.8/cmd/push.go#L104-L110)
- [`internal/git/gitops.go`](https://github.com/github/gh-stack/blob/v0.0.8/internal/git/gitops.go#L169-L201)

The command test also explicitly expects `atomic` to be false:

- [`cmd/push_test.go`](https://github.com/github/gh-stack/blob/v0.0.8/cmd/push_test.go#L60-L66)

Meanwhile, the command help and documentation say the operation uses `--force-with-lease --atomic` to provide all-or-nothing updates.

## Impact

The explicit per-branch leases are strong and prevent overwriting unexpected remote changes. However, without `--atomic`, a multi-branch push may update some stack branches before another branch is rejected. That can leave the remote stack partially updated despite the documented all-or-nothing guarantee.

This distinction matters for automation that treats a rejected stack push as proof that no remote branch changed.

## Expected behavior

`gh stack push` should pass `atomic=true` when pushing the active branches, consistent with its help text and documentation.

It would also be useful to add a test that rejects one ref in a multi-ref push and verifies that none of the remote refs update.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start in cmd/push.go at runPush and inspect the atomic argument passed to git.Push; then read internal/git/gitops.go to confirm how that option reaches Git. Use cmd/push_test.go as the existing command-level test, and add coverage for a rejected ref in a multi-ref push. Done means the command behavior matches its documented all-or-nothing guarantee.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
git, go
領域
cli, testing
issue の種類
バグ
難易度
3/5
見積もり時間
1〜2日
活発さ
静か
明瞭さ
明確に書かれている
初心者へのやさしさ
75/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。