github / github/gh-stack

`gh stack push` advertises atomic updates but invokes `git.Push` with atomic disabled

未關閉
#216 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug topic: cli - push
主要語言
Go
星號
1.5k
分支
70
平均合併
1 天 8 小時
30 天內合併 PR
7

描述

## Summary

`gh stack push` is documented as pushing every active branch with `--force-with-lease --atomic`, but the command currently invokes the Git push layer with atomicity disabled.

This is present in both `v0.0.8` and the current `main` branch.

## Current behavior

`runPush` calls:

```go
git.Push(remote, activeBranches, true, false)
```

The fourth argument is `atomic`, so this requests lease-protected pushing without `--atomic`:

- [`cmd/push.go`](https://github.com/github/gh-stack/blob/v0.0.8/cmd/push.go#L104-L110)
- [`internal/git/gitops.go`](https://github.com/github/gh-stack/blob/v0.0.8/internal/git/gitops.go#L169-L201)

The command test also explicitly expects `atomic` to be false:

- [`cmd/push_test.go`](https://github.com/github/gh-stack/blob/v0.0.8/cmd/push_test.go#L60-L66)

Meanwhile, the command help and documentation say the operation uses `--force-with-lease --atomic` to provide all-or-nothing updates.

## Impact

The explicit per-branch leases are strong and prevent overwriting unexpected remote changes. However, without `--atomic`, a multi-branch push may update some stack branches before another branch is rejected. That can leave the remote stack partially updated despite the documented all-or-nothing guarantee.

This distinction matters for automation that treats a rejected stack push as proof that no remote branch changed.

## Expected behavior

`gh stack push` should pass `atomic=true` when pushing the active branches, consistent with its help text and documentation.

It would also be useful to add a test that rejects one ref in a multi-ref push and verifies that none of the remote refs update.

貢獻指南

開啟貢獻指南

研究方向

Start in cmd/push.go at runPush and inspect the atomic argument passed to git.Push; then read internal/git/gitops.go to confirm how that option reaches Git. Use cmd/push_test.go as the existing command-level test, and add coverage for a rejected ref in a multi-ref push. Done means the command behavior matches its documented all-or-nothing guarantee.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
git, go
領域
cli, testing
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
冷清
描述清晰度
描述清楚
新手友好度
75/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。