github / github/gh-stack

`gh stack push` advertises atomic updates but invokes `git.Push` with atomic disabled

Ouverte
#216 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
bug topic: cli - push
Langage dominant
Go
Étoiles
1.5k
Forks
70
Merge moyen
1 j 8 h
PR mergées (30 j)
7

Description

## Summary

`gh stack push` is documented as pushing every active branch with `--force-with-lease --atomic`, but the command currently invokes the Git push layer with atomicity disabled.

This is present in both `v0.0.8` and the current `main` branch.

## Current behavior

`runPush` calls:

```go
git.Push(remote, activeBranches, true, false)
```

The fourth argument is `atomic`, so this requests lease-protected pushing without `--atomic`:

- [`cmd/push.go`](https://github.com/github/gh-stack/blob/v0.0.8/cmd/push.go#L104-L110)
- [`internal/git/gitops.go`](https://github.com/github/gh-stack/blob/v0.0.8/internal/git/gitops.go#L169-L201)

The command test also explicitly expects `atomic` to be false:

- [`cmd/push_test.go`](https://github.com/github/gh-stack/blob/v0.0.8/cmd/push_test.go#L60-L66)

Meanwhile, the command help and documentation say the operation uses `--force-with-lease --atomic` to provide all-or-nothing updates.

## Impact

The explicit per-branch leases are strong and prevent overwriting unexpected remote changes. However, without `--atomic`, a multi-branch push may update some stack branches before another branch is rejected. That can leave the remote stack partially updated despite the documented all-or-nothing guarantee.

This distinction matters for automation that treats a rejected stack push as proof that no remote branch changed.

## Expected behavior

`gh stack push` should pass `atomic=true` when pushing the active branches, consistent with its help text and documentation.

It would also be useful to add a test that rejects one ref in a multi-ref push and verifies that none of the remote refs update.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start in cmd/push.go at runPush and inspect the atomic argument passed to git.Push; then read internal/git/gitops.go to confirm how that option reaches Git. Use cmd/push_test.go as the existing command-level test, and add coverage for a rejected ref in a multi-ref push. Done means the command behavior matches its documented all-or-nothing guarantee.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
git, go
Domaine
cli, testing
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Calme
Clarté
Clairement spécifiée
Accessibilité débutants
75/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.