github / github/codeql

Move `ValidatedVariable` barrier from default set to individual queries

未关闭
#3,590 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement Java
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 15 小时
30 天内合并 PR
141

描述

The `ValidatedVariableAccess` is a heuristic barrier that is part of `TaintTracking::defaultTaintBarrier`, which can cause confusing FN flow (see https://github.com/github/securitylab/discussions/104). It was generally improved in https://github.com/github/codeql/pull/1344, but it is probably more appropriate to remove it from the default sanitizer and move it into the queries that want it.

Before making this change, we'll first need to identify the queries for which this sanitizer is appropriate. A starting point for this is to dig into the git history to see the context in which it was introduced (it is old).

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。