github / github/codeql

Move `ValidatedVariable` barrier from default set to individual queries

Ouverte
#3,590 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement Java
Langage dominant
CodeQL
Étoiles
10.1k
Forks
2.1k
Merge moyen
2 j 15 h
PR mergées (30 j)
141

Description

The `ValidatedVariableAccess` is a heuristic barrier that is part of `TaintTracking::defaultTaintBarrier`, which can cause confusing FN flow (see https://github.com/github/securitylab/discussions/104). It was generally improved in https://github.com/github/codeql/pull/1344, but it is probably more appropriate to remove it from the default sanitizer and move it into the queries that want it.

Before making this change, we'll first need to identify the queries for which this sanitizer is appropriate. A starting point for this is to dig into the git history to see the context in which it was introduced (it is old).

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.