github / github/codeql

Move `ValidatedVariable` barrier from default set to individual queries

Offen
#3,590 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
enhancement Java
Vorherrschende Sprache
CodeQL
Sterne
10.1k
Forks
2.1k
Ø Merge
2 T. 15 Std.
Gemergte PRs (30 T.)
141

Beschreibung

The `ValidatedVariableAccess` is a heuristic barrier that is part of `TaintTracking::defaultTaintBarrier`, which can cause confusing FN flow (see https://github.com/github/securitylab/discussions/104). It was generally improved in https://github.com/github/codeql/pull/1344, but it is probably more appropriate to remove it from the default sanitizer and move it into the queries that want it.

Before making this change, we'll first need to identify the queries for which this sanitizer is appropriate. A starting point for this is to dig into the git history to see the context in which it was introduced (it is old).

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.