github / github/codeql

Move `ValidatedVariable` barrier from default set to individual queries

Aperta
#3,590 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
enhancement Java
Lingua principale
CodeQL
Stelle
10.1k
Fork
2.1k
Merge medio
2g 15h
PR unite (30g)
141

Descrizione

The `ValidatedVariableAccess` is a heuristic barrier that is part of `TaintTracking::defaultTaintBarrier`, which can cause confusing FN flow (see https://github.com/github/securitylab/discussions/104). It was generally improved in https://github.com/github/codeql/pull/1344, but it is probably more appropriate to remove it from the default sanitizer and move it into the queries that want it.

Before making this change, we'll first need to identify the queries for which this sanitizer is appropriate. A starting point for this is to dig into the git history to see the context in which it was introduced (it is old).

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.