github / github/codeql

Move `ValidatedVariable` barrier from default set to individual queries

Open
#3,590 0 comments 0 reactions 0 assignees View on GitHub
enhancement Java
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

The `ValidatedVariableAccess` is a heuristic barrier that is part of `TaintTracking::defaultTaintBarrier`, which can cause confusing FN flow (see https://github.com/github/securitylab/discussions/104). It was generally improved in https://github.com/github/codeql/pull/1344, but it is probably more appropriate to remove it from the default sanitizer and move it into the queries that want it.

Before making this change, we'll first need to identify the queries for which this sanitizer is appropriate. A starting point for this is to dig into the git history to see the context in which it was introduced (it is old).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.