github / github/annotation-toolkit

[Feature request] Add "or" separator option for keyboard shortcut combos

Aperta
#23 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
improvement set:user-interactions
Lingua principale
Nessun dato sulla lingua
Stelle
320
Fork
33
Merge medio
36m
PR unite (30g)
2

Descrizione

### Description

Keyboard shortcut combo components currently only support + as a separator (e.g., Ctrl + C). Some keyboard interactions require an or separator to communicate alternative key combinations (e.g., Home **or** Fn + Left Arrow).

### Requested change

Add an option to use **or** (in addition to the existing **+**) when building keyboard shortcut combos.

### Considerations

There's a point where these keyboard shortcut components become over-engineered, and we may already be there. Let's try to implement this in a simple way if possible. As it is, we should simplify what's already implemented, per:
- https://github.com/github/annotation-toolkit/issues/24

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.