github / github/annotation-toolkit

[Feature request] Add "or" separator option for keyboard shortcut combos

Offen
#23 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
improvement set:user-interactions
Vorherrschende Sprache
Keine Sprachdaten
Sterne
320
Forks
33
Ø Merge
36 Min.
Gemergte PRs (30 T.)
2

Beschreibung

### Description

Keyboard shortcut combo components currently only support + as a separator (e.g., Ctrl + C). Some keyboard interactions require an or separator to communicate alternative key combinations (e.g., Home **or** Fn + Left Arrow).

### Requested change

Add an option to use **or** (in addition to the existing **+**) when building keyboard shortcut combos.

### Considerations

There's a point where these keyboard shortcut components become over-engineered, and we may already be there. Let's try to implement this in a simple way if possible. As it is, we should simplify what's already implemented, per:
- https://github.com/github/annotation-toolkit/issues/24

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.