github / github/annotation-toolkit

[Feature request] Add "or" separator option for keyboard shortcut combos

Ouverte
#23 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
improvement set:user-interactions
Langage dominant
Aucune donnée de langage
Étoiles
320
Forks
33
Merge moyen
36 min
PR mergées (30 j)
2

Description

### Description

Keyboard shortcut combo components currently only support + as a separator (e.g., Ctrl + C). Some keyboard interactions require an or separator to communicate alternative key combinations (e.g., Home **or** Fn + Left Arrow).

### Requested change

Add an option to use **or** (in addition to the existing **+**) when building keyboard shortcut combos.

### Considerations

There's a point where these keyboard shortcut components become over-engineered, and we may already be there. Let's try to implement this in a simple way if possible. As it is, we should simplify what's already implemented, per:
- https://github.com/github/annotation-toolkit/issues/24

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.