github / github/annotation-toolkit

[Feature request] Add "or" separator option for keyboard shortcut combos

Open
#23 0 comments 0 reactions 0 assignees View on GitHub
improvement set:user-interactions
Dominant language
No language data
Stars
320
Forks
33
Avg merge
36m
Merged PRs (30d)
2

Description

### Description

Keyboard shortcut combo components currently only support + as a separator (e.g., Ctrl + C). Some keyboard interactions require an or separator to communicate alternative key combinations (e.g., Home **or** Fn + Left Arrow).

### Requested change

Add an option to use **or** (in addition to the existing **+**) when building keyboard shortcut combos.

### Considerations

There's a point where these keyboard shortcut components become over-engineered, and we may already be there. Let's try to implement this in a simple way if possible. As it is, we should simplify what's already implemented, per:
- https://github.com/github/annotation-toolkit/issues/24

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.