github-tools / github-tools/github
Commits, statuses, etc. after first page are not included in results
- 主要语言
- JavaScript
- 星标
- 3.8k
- 派生
- 809
- PR 合并指标
- 30 天内没有已合并 PR
描述
Steps to reproduce:
1. Find a commit with more than 30 statuses
2. Write a script which instantiates a repo object and calls `repo.listStatuses(sha)`, where `sha` is the commit from step 1
3. Look at the list of results
Actual:
- Only the first page of results is included
- Looking at `Repository.js`, only a single HTTP request is being made:
```
listStatuses(sha, cb) {
return this._request('GET', `/repos/${this.__fullname}/commits/${sha}/statuses`, null, cb);
}
```
Expected:
- All are included, or something is implemented like the discussion in https://github.com/github-tools/github/issues/406
贡献指南
这个仓库没有索引到贡献指南
调研方向
从 Repository.js 和 listStatuses(sha) 入口点开始,然后查看 issue #406 中关于分页的讨论。使用包含超过 30 个状态的提交确认其行为,并确保结果包含所有状态,或遵循该讨论中达成一致的方法。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript
- 领域
- api
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 50/100