github-tools / github-tools/github
Commits, statuses, etc. after first page are not included in results
- Dominant language
- JavaScript
- Stars
- 3.8k
- Forks
- 809
- PR merge metrics
- No merged PRs in 30d
Description
Steps to reproduce:
1. Find a commit with more than 30 statuses
2. Write a script which instantiates a repo object and calls `repo.listStatuses(sha)`, where `sha` is the commit from step 1
3. Look at the list of results
Actual:
- Only the first page of results is included
- Looking at `Repository.js`, only a single HTTP request is being made:
```
listStatuses(sha, cb) {
return this._request('GET', `/repos/${this.__fullname}/commits/${sha}/statuses`, null, cb);
}
```
Expected:
- All are included, or something is implemented like the discussion in https://github.com/github-tools/github/issues/406
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with Repository.js and the listStatuses(sha) entry point, then review the pagination discussion in issue #406. Confirm the behavior using a commit with more than 30 statuses and ensure the results include all statuses or follow the agreed approach from that discussion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100