github-tools / github-tools/github

Commits, statuses, etc. after first page are not included in results

Abierto
#507 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
3.8k
Forks
809
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Steps to reproduce:

1. Find a commit with more than 30 statuses
2. Write a script which instantiates a repo object and calls `repo.listStatuses(sha)`, where `sha` is the commit from step 1
3. Look at the list of results

Actual:
- Only the first page of results is included
- Looking at `Repository.js`, only a single HTTP request is being made:

```
listStatuses(sha, cb) {
return this._request('GET', `/repos/${this.__fullname}/commits/${sha}/statuses`, null, cb);
}
```

Expected:
- All are included, or something is implemented like the discussion in https://github.com/github-tools/github/issues/406

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Start with Repository.js and the listStatuses(sha) entry point, then review the pagination discussion in issue #406. Confirm the behavior using a commit with more than 30 statuses and ensure the results include all statuses or follow the agreed approach from that discussion.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
api
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
50/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.