github-tools / github-tools/github
Commits, statuses, etc. after first page are not included in results
- Vorherrschende Sprache
- JavaScript
- Sterne
- 3.8k
- Forks
- 809
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Steps to reproduce:
1. Find a commit with more than 30 statuses
2. Write a script which instantiates a repo object and calls `repo.listStatuses(sha)`, where `sha` is the commit from step 1
3. Look at the list of results
Actual:
- Only the first page of results is included
- Looking at `Repository.js`, only a single HTTP request is being made:
```
listStatuses(sha, cb) {
return this._request('GET', `/repos/${this.__fullname}/commits/${sha}/statuses`, null, cb);
}
```
Expected:
- All are included, or something is implemented like the discussion in https://github.com/github-tools/github/issues/406
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Start with Repository.js and the listStatuses(sha) entry point, then review the pagination discussion in issue #406. Confirm the behavior using a commit with more than 30 statuses and ensure the results include all statuses or follow the agreed approach from that discussion.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript
- Bereich
- api
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 50/100