github-tools / github-tools/github

Commits, statuses, etc. after first page are not included in results

Open
#507 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.8k
Forks
809
PR merge metrics
No merged PRs in 30d

Description

Steps to reproduce:

1. Find a commit with more than 30 statuses
2. Write a script which instantiates a repo object and calls `repo.listStatuses(sha)`, where `sha` is the commit from step 1
3. Look at the list of results

Actual:
- Only the first page of results is included
- Looking at `Repository.js`, only a single HTTP request is being made:

```
listStatuses(sha, cb) {
return this._request('GET', `/repos/${this.__fullname}/commits/${sha}/statuses`, null, cb);
}
```

Expected:
- All are included, or something is implemented like the discussion in https://github.com/github-tools/github/issues/406

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.