getsentry / getsentry/sentry-ruby

Play nice with sorbet and tapioca

Aperta
#2,189 9 commenti 1 reazione 1 assegnatario Rivendicata da @sl0thentr0py Vedi su GitHub
Crons Feature Ruby
Lingua principale
Ruby
Stelle
987
Fork
541
Merge medio
17h 40m
PR unite (30g)
19

Descrizione

**Describe the idea**

It would be nice if the [monitor_check_ins.rb](https://github.com/getsentry/sentry-ruby/blob/3fa341cfd01d1770887a57726bc1444199c692c8/sentry-ruby/lib/sentry/cron/monitor_check_ins.rb#L44) wouldn't use `preprend`, because that means we can't adopt it alongside sorbet atm.

**Why do you think it's beneficial to most of the users**

[Sorbet](https://sorbet.org/) is a mature type checker for ruby, which is great to have in large code bases. [They decided not to support prepend](https://sorbet.org/docs/unsupported#prepend), which seams reasonable to me.

**Possible implementation**

Sorry I don't understand prepend well enough to really comment. Couldn't it be wrapped in some sort of block / yield alternative?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.