getsentry / getsentry/sentry-ruby

Play nice with sorbet and tapioca

Abierto
#2,189 9 comentarios 1 reacción 1 asignado Reclamado por @sl0thentr0py Ver en GitHub
Crons Feature Ruby
Lenguaje dominante
Ruby
Estrellas
987
Forks
541
Merge medio
17 h 40 min
PR fusionados (30 d)
19

Descripción

**Describe the idea**

It would be nice if the [monitor_check_ins.rb](https://github.com/getsentry/sentry-ruby/blob/3fa341cfd01d1770887a57726bc1444199c692c8/sentry-ruby/lib/sentry/cron/monitor_check_ins.rb#L44) wouldn't use `preprend`, because that means we can't adopt it alongside sorbet atm.

**Why do you think it's beneficial to most of the users**

[Sorbet](https://sorbet.org/) is a mature type checker for ruby, which is great to have in large code bases. [They decided not to support prepend](https://sorbet.org/docs/unsupported#prepend), which seams reasonable to me.

**Possible implementation**

Sorry I don't understand prepend well enough to really comment. Couldn't it be wrapped in some sort of block / yield alternative?

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.