getsentry / getsentry/sentry-ruby

Play nice with sorbet and tapioca

Ouverte
#2,189 9 commentaires 1 réaction 1 personne assignée Réclamée par @sl0thentr0py Voir sur GitHub
Crons Feature Ruby
Langage dominant
Ruby
Étoiles
987
Forks
541
Merge moyen
17 h 40 min
PR mergées (30 j)
19

Description

**Describe the idea**

It would be nice if the [monitor_check_ins.rb](https://github.com/getsentry/sentry-ruby/blob/3fa341cfd01d1770887a57726bc1444199c692c8/sentry-ruby/lib/sentry/cron/monitor_check_ins.rb#L44) wouldn't use `preprend`, because that means we can't adopt it alongside sorbet atm.

**Why do you think it's beneficial to most of the users**

[Sorbet](https://sorbet.org/) is a mature type checker for ruby, which is great to have in large code bases. [They decided not to support prepend](https://sorbet.org/docs/unsupported#prepend), which seams reasonable to me.

**Possible implementation**

Sorry I don't understand prepend well enough to really comment. Couldn't it be wrapped in some sort of block / yield alternative?

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.