getsentry / getsentry/sentry-ruby

Play nice with sorbet and tapioca

Offen
#2,189 9 Kommentare 1 Reaktion 1 zugewiesene Person Beansprucht von @sl0thentr0py Auf GitHub ansehen
Crons Feature Ruby
Vorherrschende Sprache
Ruby
Sterne
987
Forks
541
Ø Merge
17 Std. 40 Min.
Gemergte PRs (30 T.)
19

Beschreibung

**Describe the idea**

It would be nice if the [monitor_check_ins.rb](https://github.com/getsentry/sentry-ruby/blob/3fa341cfd01d1770887a57726bc1444199c692c8/sentry-ruby/lib/sentry/cron/monitor_check_ins.rb#L44) wouldn't use `preprend`, because that means we can't adopt it alongside sorbet atm.

**Why do you think it's beneficial to most of the users**

[Sorbet](https://sorbet.org/) is a mature type checker for ruby, which is great to have in large code bases. [They decided not to support prepend](https://sorbet.org/docs/unsupported#prepend), which seams reasonable to me.

**Possible implementation**

Sorry I don't understand prepend well enough to really comment. Couldn't it be wrapped in some sort of block / yield alternative?

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.