getsentry / getsentry/sentry-python
Investigate improving `test_transport_works`
- 主要語言
- Python
- 星號
- 2.2k
- 分支
- 669
- 平均合併
- 1 天 40 分鐘
- 30 天內合併 PR
- 212
描述
[opened by @szokeasaurusrex]
There are multiple problems with [this test](https://github.com/getsentry/sentry-python/blob/be229121608feba3033dbe84ef1884b6ba6ad3ee/tests/test_transport.py#L146):
* The test is flaky (specifically on Python 3.10)
* The flakes appear related to asserting that `stdout` and `stderr` is empty
* The test appears to be checking multiple things. It is unclear which of these is important
* e.g. maybe we should not assert anything about `stdout` and `stderr`
* The test is generally difficult to understand
* The test takes a very long time to run because it is parameterized with many different combinations and all the tests are forked
* Maybe we can reduce the combinations we check and stop forking the test
貢獻指南
評估
這個 Issue 還沒有評估資料。