getsentry / getsentry/sentry-python

Investigate improving `test_transport_works`

Ouverte
#4,287 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Python Quality Improvement Tests
Langage dominant
Python
Étoiles
2.2k
Forks
669
Merge moyen
1 j 1 h
PR mergées (30 j)
213

Description

[opened by @szokeasaurusrex]

There are multiple problems with [this test](https://github.com/getsentry/sentry-python/blob/be229121608feba3033dbe84ef1884b6ba6ad3ee/tests/test_transport.py#L146):

* The test is flaky (specifically on Python 3.10)
* The flakes appear related to asserting that `stdout` and `stderr` is empty
* The test appears to be checking multiple things. It is unclear which of these is important
* e.g. maybe we should not assert anything about `stdout` and `stderr`
* The test is generally difficult to understand
* The test takes a very long time to run because it is parameterized with many different combinations and all the tests are forked
* Maybe we can reduce the combinations we check and stop forking the test

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.