getsentry / getsentry/sentry-python

Investigate improving `test_transport_works`

Aperta
#4,287 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Python Quality Improvement Tests
Lingua principale
Python
Stelle
2.2k
Fork
669
Merge medio
1g 1h
PR unite (30g)
213

Descrizione

[opened by @szokeasaurusrex]

There are multiple problems with [this test](https://github.com/getsentry/sentry-python/blob/be229121608feba3033dbe84ef1884b6ba6ad3ee/tests/test_transport.py#L146):

* The test is flaky (specifically on Python 3.10)
* The flakes appear related to asserting that `stdout` and `stderr` is empty
* The test appears to be checking multiple things. It is unclear which of these is important
* e.g. maybe we should not assert anything about `stdout` and `stderr`
* The test is generally difficult to understand
* The test takes a very long time to run because it is parameterized with many different combinations and all the tests are forked
* Maybe we can reduce the combinations we check and stop forking the test

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.