getsentry / getsentry/sentry-python

Investigate improving `test_transport_works`

未关闭
#4,287 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Python Quality Improvement Tests
主要语言
Python
星标
2.2k
派生
669
平均合并
1 天 1 小时
30 天内合并 PR
213

描述

[opened by @szokeasaurusrex]

There are multiple problems with [this test](https://github.com/getsentry/sentry-python/blob/be229121608feba3033dbe84ef1884b6ba6ad3ee/tests/test_transport.py#L146):

* The test is flaky (specifically on Python 3.10)
* The flakes appear related to asserting that `stdout` and `stderr` is empty
* The test appears to be checking multiple things. It is unclear which of these is important
* e.g. maybe we should not assert anything about `stdout` and `stderr`
* The test is generally difficult to understand
* The test takes a very long time to run because it is parameterized with many different combinations and all the tests are forked
* Maybe we can reduce the combinations we check and stop forking the test

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。