getsentry / getsentry/sentry-python
Make ClickHouse integration work with `django-clickhouse-backend`
- Ngôn ngữ chính
- Python
- Star
- 2.2k
- Fork
- 669
- Merge trung bình
- 1 ngày 1 giờ
- Pull request đã merge (30 ngày)
- 213
Mô tả
### Problem Statement
The ClickHouse integration doesn't create spans if used in Django via `django-clickhouse-backend`.
This first surfaced in https://github.com/getsentry/sentry-python/issues/3088 where the whole integration would error out because `_sentry_span` was not set on the connection as expected. We're [patching the integration](https://github.com/getsentry/sentry-python/pull/3096) to not do anything if `_sentry_span` is not there, but it'd be good to have proper support for `django-clickhouse-backend`.
### Solution Brainstorm
Looks like the spans are not started the expected way (`clickhouse_driver.connection.Connection.send_query` is not called?), so we might need to wrap an additional function that `django-clickhouse-backend` uses to start queries.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.