getsentry / getsentry/sentry-python

Make ClickHouse integration work with `django-clickhouse-backend`

Aberta
#3,095 0 comentários 0 reações 0 responsáveis Ver no GitHub
Feature Integration: Clickhouse Python Spans
Linguagem predominante
Python
Estrelas
2.2k
Forks
669
Merge médio
1d 40min
PRs com merge (30d)
212

Descrição

### Problem Statement

The ClickHouse integration doesn't create spans if used in Django via `django-clickhouse-backend`.

This first surfaced in https://github.com/getsentry/sentry-python/issues/3088 where the whole integration would error out because `_sentry_span` was not set on the connection as expected. We're [patching the integration](https://github.com/getsentry/sentry-python/pull/3096) to not do anything if `_sentry_span` is not there, but it'd be good to have proper support for `django-clickhouse-backend`.

### Solution Brainstorm

Looks like the spans are not started the expected way (`clickhouse_driver.connection.Connection.send_query` is not called?), so we might need to wrap an additional function that `django-clickhouse-backend` uses to start queries.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.