getsentry / getsentry/sentry-python

Make ClickHouse integration work with `django-clickhouse-backend`

未關閉
#3,095 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
Feature Integration: Clickhouse Python Spans
主要語言
Python
星號
2.2k
分支
669
平均合併
1 天 1 小時
30 天內合併 PR
213

描述

### Problem Statement

The ClickHouse integration doesn't create spans if used in Django via `django-clickhouse-backend`.

This first surfaced in https://github.com/getsentry/sentry-python/issues/3088 where the whole integration would error out because `_sentry_span` was not set on the connection as expected. We're [patching the integration](https://github.com/getsentry/sentry-python/pull/3096) to not do anything if `_sentry_span` is not there, but it'd be good to have proper support for `django-clickhouse-backend`.

### Solution Brainstorm

Looks like the spans are not started the expected way (`clickhouse_driver.connection.Connection.send_query` is not called?), so we might need to wrap an additional function that `django-clickhouse-backend` uses to start queries.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。