getsentry / getsentry/sentry-javascript

Keep min. 30 seconds for replay in error mode

未關閉
#6,908 15 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

@billyvg 已經在處理了。

開始於 2024年12月16日。

Browser Improvement Replays
主要語言
TypeScript
星號
8.7k
分支
1.8k
平均合併
1 天 18 小時
30 天內合併 PR
541

描述

Currently, when in error mode, we keep up to 60 seconds of replay recording for when an error happens.

Basically, what happens is:

  • rrweb is instructed to do a full checkout every 60 seconds
  • The event buffer will generally discard anything buffered before when it receives a full checkout
  • When an error occurs, we send the whole buffer
  • This means we send anything from 0-60 seconds of replay data

IMHO this can be unexpected (it was unexpected to me, I thought it would always keep the last 60s 😅 ). I propose that we change this to keep a min. of 60 seconds (except at the very beginning of the replay, of course. So we'd send anywhere from 60-120 seconds of replay data.

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。