getsentry / getsentry/sentry-javascript

Keep min. 30 seconds for replay in error mode

Open
#6,908 15 comments 0 reactions 1 assignee Claimed by @billyvg View on GitHub
Browser Improvement Replays
Dominant language
TypeScript
Stars
8.7k
Forks
1.8k
Avg merge
1d 17h
Merged PRs (30d)
515

Description

Currently, when in error mode, we keep _up to_ 60 seconds of replay recording for when an error happens.

Basically, what happens is:

* rrweb is instructed to do a full checkout every 60 seconds
* The event buffer will generally discard anything buffered before when it receives a full checkout
* When an error occurs, we send the whole buffer
* This means we send anything from 0-60 seconds of replay data

IMHO this can be unexpected (it was unexpected to me, I thought it would always keep the last 60s 😅 ). I propose that we change this to keep a min. of 60 seconds (except at the very beginning of the replay, of course. So we'd send anywhere from 60-120 seconds of replay data.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.