getsentry / getsentry/sentry-javascript

Keep min. 30 seconds for replay in error mode

Aperta
#6,908 15 commenti 0 reazioni 1 assegnatario Rivendicata da @billyvg Vedi su GitHub
Browser Improvement Replays
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
515

Descrizione

Currently, when in error mode, we keep _up to_ 60 seconds of replay recording for when an error happens.

Basically, what happens is:

* rrweb is instructed to do a full checkout every 60 seconds
* The event buffer will generally discard anything buffered before when it receives a full checkout
* When an error occurs, we send the whole buffer
* This means we send anything from 0-60 seconds of replay data

IMHO this can be unexpected (it was unexpected to me, I thought it would always keep the last 60s 😅 ). I propose that we change this to keep a min. of 60 seconds (except at the very beginning of the replay, of course. So we'd send anywhere from 60-120 seconds of replay data.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.