getsentry / getsentry/sentry-javascript

Keep min. 30 seconds for replay in error mode

Offen
#6,908 15 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @billyvg Auf GitHub ansehen
Browser Improvement Replays
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
515

Beschreibung

Currently, when in error mode, we keep _up to_ 60 seconds of replay recording for when an error happens.

Basically, what happens is:

* rrweb is instructed to do a full checkout every 60 seconds
* The event buffer will generally discard anything buffered before when it receives a full checkout
* When an error occurs, we send the whole buffer
* This means we send anything from 0-60 seconds of replay data

IMHO this can be unexpected (it was unexpected to me, I thought it would always keep the last 60s 😅 ). I propose that we change this to keep a min. of 60 seconds (except at the very beginning of the replay, of course. So we'd send anywhere from 60-120 seconds of replay data.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.