getsentry / getsentry/sentry-javascript

bun: Stale comment in `getPerformanceIntegrations`

Aperta
#23,888 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Bun Improvement javascript
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
515

Descrizione

`packages/bun/src/sdk.ts:29` says the function swaps in the orchestrion subscribers "*only* when the orchestrion channels were actually injected". The body has no such condition; it returns `getTracingIntegrations()` unconditionally. Either the gate was dropped or the comment is left over.

**Work item.** Decide which is right. If unconditional is intended, rewrite the comment. If the gate was intended, note that it interacts with B2: gating would turn the silent no-op into an honest empty set.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start in packages/bun/src/sdk.ts:29 and inspect getPerformanceIntegrations alongside getTracingIntegrations. Review the B2 interaction described in the issue, then determine whether unconditional behavior or gating is intended; update the comment or behavior accordingly and verify that the resulting integrations behavior matches the decision.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
observability
Tipo di issue
Refactoring
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
58/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.