getsentry / getsentry/sentry-javascript

bun: Stale comment in `getPerformanceIntegrations`

Open
#23,888 1 comment 0 reactions 0 assignees View on GitHub
Bun Improvement javascript
Dominant language
TypeScript
Stars
8.7k
Forks
1.8k
Avg merge
1d 17h
Merged PRs (30d)
523

Description

`packages/bun/src/sdk.ts:29` says the function swaps in the orchestrion subscribers "*only* when the orchestrion channels were actually injected". The body has no such condition; it returns `getTracingIntegrations()` unconditionally. Either the gate was dropped or the comment is left over.

**Work item.** Decide which is right. If unconditional is intended, rewrite the comment. If the gate was intended, note that it interacts with B2: gating would turn the silent no-op into an honest empty set.

Contributor guide

Open the contributing guide

Research direction

Start in packages/bun/src/sdk.ts:29 and inspect getPerformanceIntegrations alongside getTracingIntegrations. Review the B2 interaction described in the issue, then determine whether unconditional behavior or gating is intended; update the comment or behavior accordingly and verify that the resulting integrations behavior matches the decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
observability
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.