getsentry / getsentry/sentry-javascript

bun: Stale comment in `getPerformanceIntegrations`

Abierto
#23,888 1 comentario 0 reacciones 0 asignados Ver en GitHub
Bun Improvement javascript
Lenguaje dominante
TypeScript
Estrellas
8.7k
Forks
1.8k
Merge medio
1 d 17 h
PR fusionados (30 d)
515

Descripción

`packages/bun/src/sdk.ts:29` says the function swaps in the orchestrion subscribers "*only* when the orchestrion channels were actually injected". The body has no such condition; it returns `getTracingIntegrations()` unconditionally. Either the gate was dropped or the comment is left over.

**Work item.** Decide which is right. If unconditional is intended, rewrite the comment. If the gate was intended, note that it interacts with B2: gating would turn the silent no-op into an honest empty set.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start in packages/bun/src/sdk.ts:29 and inspect getPerformanceIntegrations alongside getTracingIntegrations. Review the B2 interaction described in the issue, then determine whether unconditional behavior or gating is intended; update the comment or behavior accordingly and verify that the resulting integrations behavior matches the decision.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
observability
Tipo de issue
Refactorización
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
58/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.