getsentry / getsentry/sentry-javascript
bun: Stale comment in `getPerformanceIntegrations`
- Langage dominant
- TypeScript
- Étoiles
- 8.7k
- Forks
- 1.8k
- Merge moyen
- 1 j 17 h
- PR mergées (30 j)
- 523
Description
`packages/bun/src/sdk.ts:29` says the function swaps in the orchestrion subscribers "*only* when the orchestrion channels were actually injected". The body has no such condition; it returns `getTracingIntegrations()` unconditionally. Either the gate was dropped or the comment is left over.
**Work item.** Decide which is right. If unconditional is intended, rewrite the comment. If the gate was intended, note that it interacts with B2: gating would turn the silent no-op into an honest empty set.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Start in packages/bun/src/sdk.ts:29 and inspect getPerformanceIntegrations alongside getTracingIntegrations. Review the B2 interaction described in the issue, then determine whether unconditional behavior or gating is intended; update the comment or behavior accordingly and verify that the resulting integrations behavior matches the decision.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- typescript
- Domaine
- observability
- Type d'issue
- Refactorisation
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- Active
- Clarté
- Plutôt claire
- Accessibilité débutants
- 58/100