getsentry / getsentry/sentry-javascript

No isolation scope forking for async background tasks

Đang mở
#19,596 2 bình luận 0 reaction 0 người được giao Xem trên GitHub
Bug Nest.js
Ngôn ngữ chính
TypeScript
Star
8.7k
Fork
1.8k
Merge trung bình
1 ngày 17 giờ
Pull request đã merge (30 ngày)
523

Mô tả

We currently do not fork isolation scopes for async background tasks in nestjs. That's why any Sentry data generated during these tasks get written to the default isolation scope, which then gets forked during http requests. Therefore data generated during async activity leaks into http requests (see for instance [leaking breadcrumbs]()). We need to ensure that we properly isolate async background tasks.

Solution Brainstorm: We could try to find a single entrypoint but it would be good to write new instrumentations for the most important use cases here anyway (to also capture errors and do some tracing). For `@nestjs/event-emitter` we have instrumentation already, so we just need to add an isolation scope for other setups this is lacking (tracked in [JS-1895](https://linear.app/getsentry/issue/JS-1895/add-instrumentations-for-async-background-task-apis)).

[Reproduction](https://github.com/getsentry/repro/pull/23)

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.