getsentry / getsentry/sentry-javascript

No isolation scope forking for async background tasks

Aperta
#19,596 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Bug Nest.js
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
515

Descrizione

We currently do not fork isolation scopes for async background tasks in nestjs. That's why any Sentry data generated during these tasks get written to the default isolation scope, which then gets forked during http requests. Therefore data generated during async activity leaks into http requests (see for instance [leaking breadcrumbs]()). We need to ensure that we properly isolate async background tasks.

Solution Brainstorm: We could try to find a single entrypoint but it would be good to write new instrumentations for the most important use cases here anyway (to also capture errors and do some tracing). For `@nestjs/event-emitter` we have instrumentation already, so we just need to add an isolation scope for other setups this is lacking (tracked in [JS-1895](https://linear.app/getsentry/issue/JS-1895/add-instrumentations-for-async-background-task-apis)).

[Reproduction](https://github.com/getsentry/repro/pull/23)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.