getsentry / getsentry/sentry-javascript

No isolation scope forking for async background tasks

Offen
#19,596 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Bug Nest.js
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
523

Beschreibung

We currently do not fork isolation scopes for async background tasks in nestjs. That's why any Sentry data generated during these tasks get written to the default isolation scope, which then gets forked during http requests. Therefore data generated during async activity leaks into http requests (see for instance [leaking breadcrumbs]()). We need to ensure that we properly isolate async background tasks.

Solution Brainstorm: We could try to find a single entrypoint but it would be good to write new instrumentations for the most important use cases here anyway (to also capture errors and do some tracing). For `@nestjs/event-emitter` we have instrumentation already, so we just need to add an isolation scope for other setups this is lacking (tracked in [JS-1895](https://linear.app/getsentry/issue/JS-1895/add-instrumentations-for-async-background-task-apis)).

[Reproduction](https://github.com/getsentry/repro/pull/23)

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.