getsentry / getsentry/sentry-javascript

Always attach some URL/target data point to fetch/xhr/request errors

Đang mở
#13,168 0 bình luận 1 reaction 0 người được giao Xem trên GitHub
Browser Errors Improvement
Ngôn ngữ chính
TypeScript
Star
8.7k
Fork
1.8k
Merge trung bình
1 ngày 17 giờ
Pull request đã merge (30 ngày)
515

Mô tả

### Description

The Sentry Chief Product Officer has brought to our attention that Fetch errors sometimes suck. ([example that will expire in 90 days](https://peated.sentry.io/issues/5656229682/?referrer=regression_activity-email¬ification_uuid=add413c0-019a-4b87-ae37-608eb905a605))

![Image](https://github.com/user-attachments/assets/a8106189-e78e-486f-b5c8-5373af5cc61d)

We technically have a stack trace here but sourcemaps are broken so the user has basically no idea what fetch request failed. It's very hard to gauge from breadcrumbs what exact request failed.

Side note, the fetch call that failed looked like `fetch("")`. We render this as in the product, you guessed it `""`. Which is crap because it actually means the request went to the current route. We should at least coerce that string to `URL(fetchTarget, window.location.href).toString()` in the SDK.

![Image](https://github.com/user-attachments/assets/2deb0b10-8afd-4efb-8171-592eb98e4859)

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.