getsentry / getsentry/sentry-javascript

Always attach some URL/target data point to fetch/xhr/request errors

Ouverte
#13,168 0 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
Browser Errors Improvement
Langage dominant
TypeScript
Étoiles
8.7k
Forks
1.8k
Merge moyen
1 j 17 h
PR mergées (30 j)
515

Description

### Description

The Sentry Chief Product Officer has brought to our attention that Fetch errors sometimes suck. ([example that will expire in 90 days](https://peated.sentry.io/issues/5656229682/?referrer=regression_activity-email¬ification_uuid=add413c0-019a-4b87-ae37-608eb905a605))

![Image](https://github.com/user-attachments/assets/a8106189-e78e-486f-b5c8-5373af5cc61d)

We technically have a stack trace here but sourcemaps are broken so the user has basically no idea what fetch request failed. It's very hard to gauge from breadcrumbs what exact request failed.

Side note, the fetch call that failed looked like `fetch("")`. We render this as in the product, you guessed it `""`. Which is crap because it actually means the request went to the current route. We should at least coerce that string to `URL(fetchTarget, window.location.href).toString()` in the SDK.

![Image](https://github.com/user-attachments/assets/2deb0b10-8afd-4efb-8171-592eb98e4859)

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.