getsentry / getsentry/sentry-javascript

Always attach some URL/target data point to fetch/xhr/request errors

Aperta
#13,168 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
Browser Errors Improvement
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
515

Descrizione

### Description

The Sentry Chief Product Officer has brought to our attention that Fetch errors sometimes suck. ([example that will expire in 90 days](https://peated.sentry.io/issues/5656229682/?referrer=regression_activity-email¬ification_uuid=add413c0-019a-4b87-ae37-608eb905a605))

![Image](https://github.com/user-attachments/assets/a8106189-e78e-486f-b5c8-5373af5cc61d)

We technically have a stack trace here but sourcemaps are broken so the user has basically no idea what fetch request failed. It's very hard to gauge from breadcrumbs what exact request failed.

Side note, the fetch call that failed looked like `fetch("")`. We render this as in the product, you guessed it `""`. Which is crap because it actually means the request went to the current route. We should at least coerce that string to `URL(fetchTarget, window.location.href).toString()` in the SDK.

![Image](https://github.com/user-attachments/assets/2deb0b10-8afd-4efb-8171-592eb98e4859)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.