getsentry / getsentry/sentry-java

Ok Http Retry Tracking using the EventListner API?

オープン
#4,161 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る
Android Improvement Spans
主要言語
Kotlin
スター
1.4k
フォーク
478
平均マージ
2日 23時間
マージ済み PR(30日)
67

説明

### Description

Hello Team, I have a question about how we are tracking the network metrics using the OkHttp EventListenerAPI here - https://github.com/getsentry/sentry-java/blob/main/sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpEventListener.kt

From my understanding, with the current implementation, if a request is retried, the event listener only captures metrics for the latest attempt and does not track metrics for each retry separately. So, if there are three requests (one original and two retries), we only see metrics for the last one. I understand that some metrics, like CONNECT, SSL, and DNS, would only be recorded for the initial request since OkHttp reuses the connection. However, other metrics could still be relevant for retries.

Was there a specific reason for implementing it this way?

Looking forward to your insights!

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。