getsentry / getsentry/sentry-java

Ok Http Retry Tracking using the EventListner API?

Aperta
#4,161 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Android Improvement Spans
Lingua principale
Kotlin
Stelle
1.4k
Fork
478
Merge medio
2g 23h
PR unite (30g)
67

Descrizione

### Description

Hello Team, I have a question about how we are tracking the network metrics using the OkHttp EventListenerAPI here - https://github.com/getsentry/sentry-java/blob/main/sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpEventListener.kt

From my understanding, with the current implementation, if a request is retried, the event listener only captures metrics for the latest attempt and does not track metrics for each retry separately. So, if there are three requests (one original and two retries), we only see metrics for the last one. I understand that some metrics, like CONNECT, SSL, and DNS, would only be recorded for the initial request since OkHttp reuses the connection. However, other metrics could still be relevant for retries.

Was there a specific reason for implementing it this way?

Looking forward to your insights!

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.